[webkit-reviews] review granted: [Bug 73033] [Chromium] WebGL active texture state corrupted upon WebGL contents present : [Attachment 116467] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Jeff Timanus <twiz at chromium.org>'s
request for review:
Bug 73033: [Chromium] WebGL active texture state corrupted upon WebGL contents
present
https://bugs.webkit.org/show_bug.cgi?id=73033

Attachment 116467: Patch
https://bugs.webkit.org/attachment.cgi?id=116467&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116467&action=review


Looks good; nice job on the test case. A few minor nits in the test that can be
cleaned up later. r=me

> LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html:22
> +var requestAnimationFrame;

nit: this variable is no longer needed.

> LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html:26
> +  // before reaching this point.  If the texture state was corruted, then 

nit: corruted -> corrupted

> LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html:42
> +  canvas.width = 50; canvas.height = 50;

nit: not needed

> LayoutTests/fast/canvas/webgl/webgl-texture-binding-preserved.html:63
> +  setTimeout(draw, 100);

nit: add comment that requestAnimationFrame was tried for this purpose and it
didn't work. Also that the 100 ms timeout seemed to reproduce the problem 100%
of the time even during fast page reloads.