[webkit-reviews] review requested: [Bug 72538] WebWorker threads can outlive the QApplication instance : [Attachment 116462] wait for WorkerThread only for Qt platform

[bugzilla-daemon at webkit.org]

Andrew Wason <rectalogic at rectalogic.com> has asked  for review:
Bug 72538: WebWorker threads can outlive the QApplication instance
https://bugs.webkit.org/show_bug.cgi?id=72538

Attachment 116462: wait for WorkerThread only for Qt platform
https://bugs.webkit.org/attachment.cgi?id=116462&action=review

------- Additional Comments from Andrew Wason <rectalogic at rectalogic.com>
I've tried a number of approaches but can't see how to do this safely with Qt.
Part of the problem is knowing when the application is shutting down in order
to safely wait for the workers - connecting to QCoreApplication::aboutToQuit is
too early because any QWebPages may not be destroyed yet, so they won't have
told their workers to quit. Connecting to QCoreApplication::destroyed is too
late because some workers may still be starting up and crash because
QCoreApplication::instance() is now NULL.

Attached patch makes waiting for WorkerThreads in stop() conditional on
PLATFORM(QT)