[webkit-reviews] review granted: [Bug 72553] Move readyState from TextTrack to HTMLTrackElement : [Attachment 116384] bringin' back the Reflect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 23 18:08:15 PST 2011
Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 72553: Move readyState from TextTrack to HTMLTrackElement
https://bugs.webkit.org/show_bug.cgi?id=72553
Attachment 116384: bringin' back the Reflect
https://bugs.webkit.org/attachment.cgi?id=116384&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116384&action=review
> Source/WebCore/html/HTMLTrackElement.h:57
> + enum ReadyState { NONE = 0, LOADING = 1, LOADED = 2, HTML_ERROR = 3 };
Although we used "HTML_ERROR" before, I don't think it is a good choice because
"HTML" is too generic. Maybe "TRACK_ERROR" instead?
More information about the webkit-reviews
mailing list