[webkit-reviews] review granted: [Bug 73031] Pointer Lock: MouseEvents constructed using movement from PlatformMouseEvent : [Attachment 116395] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Vincent Scheib
<scheib at chromium.org>'s request for review:
Bug 73031: Pointer Lock: MouseEvents constructed using movement from
PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=73031

Attachment 116395: Patch
https://bugs.webkit.org/attachment.cgi?id=116395&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116395&action=review


ok with nits:

> Source/WebCore/ChangeLog:3
> +	   Pointer Lock: MouseEvents constructed using movement from
PlatformMouseEvent

Usually, I try to formulate the bug title as "here's what I am doing". In this
case, I would title it:

Pointer Lock: Plumb movement coordinates from PlatformMouseEvent to
MouseEvents.

> Source/WebCore/ChangeLog:8
> +	   No new tests.

This needs an explanation, like:

No tests for now, but this patch gets us closer to being able to write layout
tests for pointer lock.