[webkit-reviews] review denied: [Bug 73038] Fix Aspect Ratio Property Inheritance : [Attachment 116401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 23 12:45:15 PST 2011


Ojan Vafai <ojan at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 73038: Fix Aspect Ratio Property Inheritance
https://bugs.webkit.org/show_bug.cgi?id=73038

Attachment 116401: Patch
https://bugs.webkit.org/attachment.cgi?id=116401&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Can you add a test for this? The computed style on an element that inherits the
value should be wrong without this patch, right?

Also, now that I think about it, it doesn't make sense to me that this value
would inherit. http://www.xanthir.com/blog/b4810 doesn't say whether it should,
but I think it probably shouldn't. Maybe bring this up on www-style and then
we'll probably want to delete this chunk of code.


More information about the webkit-reviews mailing list