[webkit-reviews] review denied: [Bug 73039] [Web Intents] Flagged-off implementation of an intent tag for registration. : [Attachment 116390] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 73039: [Web Intents] Flagged-off implementation of an intent tag for
registration.
https://bugs.webkit.org/show_bug.cgi?id=73039

Attachment 116390: Patch
https://bugs.webkit.org/attachment.cgi?id=116390&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116390&action=review


> Source/WebCore/html/HTMLIntentElement.cpp:51
> +    document()->frame()->loader()->client()->registerIntentService(

given a Document, the frame() method can return null.  however, i'm not sure if
it can really be null in this case.  i see other insertedIntoDocument()
implementations checking frame() though.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1630
> +    WebCore::KURL serviceURL(baseURL, href); // need TextEncoding?

I think you should be using {Web}Document::completeURL() for this instead.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:1634
> +	   m_webFrame->client()->registerIntentService(webFrame(), service);

nit: use m_webFrame instead of webFrame()

> Source/WebKit/chromium/src/FrameLoaderClientImpl.h:211
> +    virtual void registerIntentService(

when you are inside the implementation of WebKit, you don't need the WTF::
prefix on WTF types.

> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,

This class is also defined in the patch from
https://bugs.webkit.org/show_bug.cgi?id=73036.