[webkit-reviews] review denied: [Bug 73036] Add simple implementation for web intents chromium API data classes. : [Attachment 116388] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 73036: Add simple implementation for web intents chromium API data classes.
https://bugs.webkit.org/show_bug.cgi?id=73036

Attachment 116388: Patch
https://bugs.webkit.org/attachment.cgi?id=116388&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116388&action=review


> Source/WebKit/chromium/public/WebIntent.h:44
> +    WebIntent(const WebString& action, const WebString& type, const
WebString& data, int identifier);

public, non-inline methods need to be annotated with WEBKIT_EXPORT or else you
will break the shared library build.

also, please note that we normally do not export constructors.	instead, we
write initialize() methods, and export
those.	the constructor can call the initialize() method.

in this case, though... I wonder... will there be no WebCore::Intent class?  if
there is such a class, maybe you
want the constructor to take that instead?

the same issue applies to WebIntentServiceInfo.