[webkit-reviews] review granted: [Bug 73024] Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead. : [Attachment 116373] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 23 09:26:00 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 73024: Web Inspector: get rid of the WebInspector.mainResource, use
WebInspector.inspectedPageURL instead.
https://bugs.webkit.org/show_bug.cgi?id=73024

Attachment 116373: Patch
https://bugs.webkit.org/attachment.cgi?id=116373&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116373&action=review


> Source/WebCore/inspector/front-end/AuditsPanel.js:135
> +	   var mainResourceURL = WebInspector.inspectedPageURL;

I don't think inspectedPageUrl is a good name, it will be confusing in case of
worker inspector, could you rename it to mainResourceURL or something like
that? Same for inspectedPageDomain


More information about the webkit-reviews mailing list