[webkit-reviews] review denied: [Bug 66477] [GTK] Html5 Notification, testing facilities : [Attachment 114466] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Alexandre Mazari
<scaroo at gmail.com>'s request for review:
Bug 66477: [GTK] Html5 Notification, testing facilities
https://bugs.webkit.org/show_bug.cgi?id=66477

Attachment 114466: Patch
https://bugs.webkit.org/attachment.cgi?id=114466&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=114466&action=review


Thanks! This looks quite good, I found some little nits to fix though :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1125
> +    return g_strdup_printf("%s://%s",
> +			      webkit_security_origin_get_protocol(origin),
> +			      webkit_security_origin_get_host(origin));

This can fit in one or two lines.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1176
> +	 JSStringRef jsOrigin = JSStringCreateWithUTF8CString(originStr.get());


Weird indentation :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1197
> +    bool permited =
gLayoutTestController->checkDesktopNotificationPermission(jsOrigin);

s/permited/allowed ?

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:1037
> +    if (!match)

notificationTitle is leaked in this case.