[webkit-reviews] review denied: [Bug 72353] [SOUP][WK2] Implement the functions to manager cookies in CookieJar for WebKit2 : [Attachment 115099] patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Jongseok Yang
<js45.yang at samsung.com>'s request for review:
Bug 72353: [SOUP][WK2] Implement the functions to manager cookies in CookieJar
for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72353

Attachment 115099: patch
https://bugs.webkit.org/attachment.cgi?id=115099&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115099&action=review


Looks fine to me, but I have some style nits.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:131
> +    GSList* cookies;
> +    GSList* item;
> +    SoupCookie* soupCookie;
> +    char* domain;
> +

In WebKit we typically declare variables when they are first used and in the
scope they are used.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:150
> +    GSList* cookies;
> +    GSList* item;
> +    SoupCookie* soupCookie;
> +    char* domain;

Ditto.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:168
> +    GSList* cookies;
> +    GSList* item;

Ditto.