[webkit-reviews] review granted: [Bug 72893] [QT][WK2] Add (experimental) viewport attributes view to MiniBrowser/qt : [Attachment 116234] Updated proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has granted Michael Brüning
<michael.bruning at nokia.com>'s request for review:
Bug 72893: [QT][WK2] Add (experimental) viewport attributes view to
MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=72893

Attachment 116234: Updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=116234&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116234&action=review


lgtm, a few fixups before landing please

> ChangeLog:9
> +	   attributes, which contains the viewport scalability and layout

viewportAttributes

> Source/WebKit/qt/ChangeLog:9
> +	   attributes, which contains the viewport scalability and layout

viewportAttributes

> Source/WebKit2/ChangeLog:9
> +	   attributes, which contains the viewport scalability and layout

viewportAttributes

> Tools/ChangeLog:9
> +	   attributes, which contains the viewport scalability and layout

viewportAttributes

> Tools/MiniBrowser/qt/qml/BrowserWindow.qml:37
> +    property alias viewportattributesitem: viewportAttributesItem

normal lower-case+title-case naming apply (i see that the webview variable does
not follow this, it should)