[webkit-reviews] review granted: [Bug 71050] [Microdata] Support for properties attribute. : [Attachment 115575] Updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 71050: [Microdata] Support for properties attribute.
https://bugs.webkit.org/show_bug.cgi?id=71050

Attachment 115575: Updated patch
https://bugs.webkit.org/attachment.cgi?id=115575&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115575&action=review


Below are a few minor nits.  It would be nice to include more tests, but it's
always nicer to include more tests.  :)

> Source/WebCore/dom/Node.h:86
> +class DOMSettableTokenList;

This shouldn't be guarded by this macro because it's defined outside of
ENABLE(MICRODATA)

> Source/WebCore/dom/NodeRareData.h:29
> +#include "DOMSettableTokenList.h"

Same here.

> Source/WebCore/html/CollectionType.h:58
> +	   ItemProperties, // Microdata item properties in the document

Bad indent

> Source/WebCore/html/HTMLPropertiesCollection.cpp:33
> +#if ENABLE(MICRODATA)

We usually have a blank line below this line.

> Source/WebCore/html/HTMLPropertiesCollection.cpp:69
> +    Vector<Node*> memory, pending;

We usually don't use compound declarations.

> Source/WebCore/html/HTMLPropertiesCollection.h:38
> +namespace WebCore {

We usually have a blank line below this line.