[webkit-reviews] review denied: [Bug 72667] [Chromium] Fix broken DRT build for Aura Linux : [Attachment 116238] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 22 23:37:39 PST 2011
Tony Chang <tony at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 72667: [Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667
Attachment 116238: Patch
https://bugs.webkit.org/attachment.cgi?id=116238&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116238&action=review
> Source/WebKit/chromium/WebKit.gyp:1097
> + ['use_aura==0', {
> + 'sources/': [
> + ['exclude', 'TestShellStub\\.cpp$'],
Is this needed? It looks like we only add the file if it's aura or android.
> Tools/DumpRenderTree/chromium/EventSender.cpp:579
> +#if OS(LINUX) && USE(GTK)
What happened to the WTF_USE_GTK define in WebKit.gyp?
More information about the webkit-reviews
mailing list