[webkit-reviews] review granted: [Bug 71705] CSS 2.1 failure: border-collapse-offset-002.htm fails : [Attachment 116258] Patch

Tue Nov 22 22:40:33 PST 2011

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 71705: CSS 2.1 failure: border-collapse-offset-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=71705

Attachment 116258: Patch
https://bugs.webkit.org/attachment.cgi?id=116258&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116258&action=review

> Right, I've added some tests for absolutely positioned captions but I'm not
sure I've captured the use-case you envisage here.

The test cases makes sense and cover what I had in mind, thanks!

> Source/WebCore/ChangeLog:7
> +

This is missing the tests that you added in LayoutTests!

> LayoutTests/ChangeLog:15
> +	   Affected tables/mozilla tests are rebaselined in a follow-up patch.

s/are/will be/.

I am assuming those rebaselines are small and inconsequential (like some minor
pixel / dump differences). Make sure you post the updates on this bug for
people to follow those.

> LayoutTests/fast/css/caption-width-absolute-position-offset-top.htm:1
> +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">

For custom tests, we really prefer HTML5 doctype:

<!DOCTYPE html>