[webkit-reviews] review denied: [Bug 72996] [chromium] Add page-scale animation support to Impl thread : [Attachment 116303] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 72996: [chromium] Add page-scale animation support to Impl thread
https://bugs.webkit.org/show_bug.cgi?id=72996

Attachment 116303: Patch
https://bugs.webkit.org/attachment.cgi?id=116303&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116303&action=review


> Source/WebKit/chromium/public/WebCompositor.h:47
> +    virtual void handlePageScaleAnimationEvent(const
WebPageScaleAnimationEvent&) = 0;

since WebPageScaleAnimationEvent inherits from WebInputEvent, you don't need
this method.  just use handleInputEvent.

> Source/WebKit/chromium/public/WebInputEvent.h:371
> +class WebPageScaleAnimationEvent : public WebInputEvent {

this seems like it could/should be represented as a type of gesture event.  or
maybe
we should derive from WebGestureEvent and call this a WebPageScaleGestureEvent?