[webkit-reviews] review denied: [Bug 71757] WebWorkerRunLoop wrapper around WorkerRunLoop : [Attachment 116305] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 22 18:46:19 PST 2011
David Levin <levin at chromium.org> has denied David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 71757: WebWorkerRunLoop wrapper around WorkerRunLoop
https://bugs.webkit.org/show_bug.cgi?id=71757
Attachment 116305: Patch
https://bugs.webkit.org/attachment.cgi?id=116305&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116305&action=review
Just address that one thing about initialization an we're good. Or you could
tell me why you think it is ok to take a lock there everytime. (I'm hesitant to
have that because I had to clear up something similar in wtf and it is much
harder to clean up later than it is to address it right now.)
> Source/WebKit/chromium/ChangeLog:35
> + WebWorkerRunLoop TLS to |this|.
Inits WebWorkerRunLoop TLS.
I don't care if you change this. Just showing how it could even be more concise
to minimize your typing :).
> Source/WebKit/chromium/ChangeLog:37
> + WebWorkerRunLoop TLS to 0.
Clears WebWorkerRunLoop TLS.
More information about the webkit-reviews
mailing list