[webkit-reviews] review granted: [Bug 72660] Remove notifyChange from the public interface of CSSMutableStyleDeclaration : [Attachment 116288] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 22 17:23:48 PST 2011


Ojan Vafai <ojan at chromium.org> has granted Rafael Weinstein
<rafaelw at chromium.org>'s request for review:
Bug 72660: Remove notifyChange from the public interface of
CSSMutableStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=72660

Attachment 116288: Patch
https://bugs.webkit.org/attachment.cgi?id=116288&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This patch looks safe to me. The only place it changes behavior is in
HTMLElement.cpp when setting contentEditable to false, we now notifyChanged
where we didn't used to. I don't see how this could cause a bug and I think it
was probably wrong to pass false here. Looks like it's been this way since it
was first checked in http://trac.webkit.org/changeset/12984.


More information about the webkit-reviews mailing list