[webkit-reviews] review granted: [Bug 72950] [DRT Chromium] Set right default value to baseURL in LayoutTestController::queueLoadHTMLString : [Attachment 116216] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 22 09:35:27 PST 2011


Tony Chang <tony at chromium.org> has granted Johnny(Jianning) Ding
<jnd at chromium.org>'s request for review:
Bug 72950: [DRT Chromium] Set right default value to baseURL in
LayoutTestController::queueLoadHTMLString
https://bugs.webkit.org/show_bug.cgi?id=72950

Attachment 116216: patch v1
https://bugs.webkit.org/attachment.cgi?id=116216&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116216&action=review


> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:575
> +	   // FIXME: Should use the URL of current document as default if it is
specified?

Nit: I would remove this comment since it seems like this is intentional.


More information about the webkit-reviews mailing list