[webkit-reviews] review granted: [Bug 72920] Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels. : [Attachment 116156] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 72920: Web Inspector: Extract SplitView from Panel.createSidebar() method
and reuse in Elements and Scripts panels.
https://bugs.webkit.org/show_bug.cgi?id=72920

Attachment 116156: Patch
https://bugs.webkit.org/attachment.cgi?id=116156&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116156&action=review


Please test this thoroughly prior to landing.

> Source/WebCore/inspector/front-end/ElementsPanel.js:42
> +    this.createSplitView(this.element,
WebInspector.SplitView.SidebarPosition.Right, 325);

Please introduce explicit named "const initialSidebarWidth = 325;" above this
line.

> Source/WebCore/inspector/front-end/ElementsPanel.js:44
> +    this.splitView.minimalMainWidthPercent = 34;

ditto

> Source/WebCore/inspector/front-end/Panel.js:125
> +	* @param {string=} position

You can try using "enum" type annotation.

> Source/WebCore/inspector/front-end/SplitView.js:43
> +    this.leftElement = document.createElement("div");

You could probably make some of these private.