[webkit-reviews] review denied: [Bug 72899] Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor : [Attachment 116107] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 72899: Web Inspector: [Extensions API][refactoring] remove dependencies on
the ExtensionsServer from most of the insepctor
https://bugs.webkit.org/show_bug.cgi?id=72899

Attachment 116107: Patch
https://bugs.webkit.org/attachment.cgi?id=116107&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116107&action=review


> Source/WebCore/inspector/front-end/ExtensionServer.js:526
> +	  
this._registerAutosubscriptionHandler("panel-objectSelected-elements",

Could you introduce the constants for these?

> Source/WebCore/inspector/front-end/Resource.js:865
> +	  
WebInspector.Resource.notifications.dispatchEventToListeners(WebInspector.Resou
rce.Events.ResourceContentCommitted, { resource: this, content: newContent });

Could you please dispatch this event on the resource tree model instead?