[webkit-reviews] review denied: [Bug 71991] Spellcheck should be able to run asynchronously : [Attachment 116164] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 71991: Spellcheck should be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=71991

Attachment 116164: Patch
https://bugs.webkit.org/attachment.cgi?id=116164&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116164&action=review


Is it possible to add a test that modify the checking range content during the
spellcheck request is in flight?

> Source/WebCore/ChangeLog:7
> +

Could you add some detailed explanation here?
The bug summary  isn't enough.

> Source/WebCore/editing/Editor.cpp:1882
> +	       if (asynchronous)

It looks async check and m_spellChecker invocation can be a part of
markAllMisspellingsAndBadGrammarInRanges().

> Source/WebCore/editing/SpellChecker.cpp:134
> +    if (shouldMarkGrammar)

Maybe body of this if() statement should be a part of the if clause above.