[webkit-reviews] review denied: [Bug 59670] [chromium] Use data decoding swizzle for turbo JPEG image decoding : [Attachment 115775] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 59670: [chromium] Use data decoding swizzle for turbo JPEG image decoding
https://bugs.webkit.org/show_bug.cgi?id=59670

Attachment 115775: Patch
https://bugs.webkit.org/attachment.cgi?id=115775&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115775&action=review


Thanks for pushing this through. A little more build infrastructure work is
needed.

> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:73
> +#if PLATFORM(CHROMIUM) && USE(SKIA) && ASSUME_LITTLE_ENDIAN

This #if test is too fragile. It might be the case that Chromium stops using
libjpeg-turbo. See in particular src/third_party/libjpeg_turbo/libjpeg.gyp; it
looks like on Chrome OS the system JPEG library is used, which I think would
result in the wrong code path being taken here. If that happened, would this
code break? Alternatively, other ports might start using libjpeg-turbo.

I think this should be written as "#if USE(LIBJPEG_TURBO) && ...".
Conditionally define WTF_USE_LIBJPEG_TURBO in Source/WebKit/chromium/WebKit.gyp
based on a gyp variable set in libjpeg.gyp.