[webkit-reviews] review granted: [Bug 72688] [chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result : [Attachment 116118] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 72688: [chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix
double-drawing issues that result
https://bugs.webkit.org/show_bug.cgi?id=72688

Attachment 116118: Patch
https://bugs.webkit.org/attachment.cgi?id=116118&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116118&action=review


R=me

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:85
> +void CCLayerTreeHostImpl::animate(double frameBeginTime)

nit: frameBeginTimeMs please, to help out whoever ends up implementing this
stub

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:291
> +    return WTF::monotonicallyIncreasingTime() * 1000.0;

nit: remove WTF:: prefix, this function's in the global namespace

> Source/WebKit/chromium/src/WebCompositorImpl.cpp:135
> +void WebCompositorImpl::willDraw(double frameBeginTime)

nit: frameBeginTimeMs please to make things clearer for whoever implements the
stub

> Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp:223
> +	       if (j == 1)
> +		   state.didEnterVSync();

for symmetry, should this call didLeaveVSync() if j==0 ?