[webkit-reviews] review denied: [Bug 69451] Adding gamepad support : [Attachment 116126] add apparently newly-needed chromium deps

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 69451: Adding gamepad support
https://bugs.webkit.org/show_bug.cgi?id=69451

Attachment 116126: add apparently newly-needed chromium deps
https://bugs.webkit.org/attachment.cgi?id=116126&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116126&action=review


> Source/WebCore/platform/Gamepads.h:35
> +void sampleGamepads(GamepadList* into);

Can we put this in Source/WebCore/platform/gamepad/Gamepads.h ?  I presume
there will be more gamepad-related files in platform.

> Source/WebKit/chromium/DEPS:35
> -  'chromium_rev': '109696'
> +  'chromium_rev': '110994'

Please roll Chromium DEPS in a separate patch.

> Source/WebKit/chromium/src/Gamepads.cpp:38
> +namespace WebCore {

Code in the WebCore namespace should be in WebCore.

> Source/WebKit/chromium/src/Gamepads.cpp:48
> +    for (unsigned i = 0; i < WebKit::WebGamepads::itemsLengthCap; ++i) {

Code in the WebCore namespace should not refer to any code in the WebKit
namespace.