[webkit-reviews] review denied: [Bug 69870] [Chromium] Empty API for web intents : [Attachment 115877] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 69870: [Chromium] Empty API for web intents
https://bugs.webkit.org/show_bug.cgi?id=69870

Attachment 115877: Patch
https://bugs.webkit.org/attachment.cgi?id=115877&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115877&action=review


> Source/WebKit/chromium/public/WebFrame.h:554
> +    virtual void handleIntentFailure(const WebString&, int intentId) = 0;

nit: I think it would be better to list the intentIdentifier first since that
identifies the intent.	the WebString is just payload, so it seems secondary.

nit: spell out intentIdentifier since this corresponds to
WebIntent::identifier().
(it helps to keep these as similar as possible to strengthen their
relationship.)

> Source/WebKit/chromium/public/WebFrameClient.h:392
> +    // the WebFrame starting the activity. The |intentId| is an arbitrary

nit: fix this comment.	it refers to "intentId" which doesn't exist as a direct
parameter to this method.

> Source/WebKit/chromium/public/WebIntentServiceInfo.h:40
> +// The |url| is the location of the handler page registered by the service.

nit: Move these comments to be above their respective method groups.  e.g.:

  // The location of the handler page registered by the service.
  WEBKIT_EXPORT WebURL url() const;
  WEBKIT_EXPORT void setURL(const WebURL&);

^^^ This way you don't have to repeat the name of the property.

> Source/WebKit/chromium/public/WebIntentServiceInfo.h:53
> +    WEBKIT_EXPORT WebString url() const;

I think you meant url() to return WebURL?