[webkit-reviews] review denied: [Bug 72715] Implement AccessKeyLabel attribute. : [Attachment 115935] proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 72715: Implement AccessKeyLabel attribute.
https://bugs.webkit.org/show_bug.cgi?id=72715

Attachment 115935: proposed patch
https://bugs.webkit.org/attachment.cgi?id=115935&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> So is it good if we add member to RareData for caching?

Memory impact would likely be too large. I was thinking of caching just the
modifiers in a static variable.

> Should we add "Option" to this enum
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/PlatformKeyboardEv
ent.h#L85 for mac specific?

No. For internal purposes, Alt is just fine, it's the same key, just named
differently. Some modern Apple keyboard have both "option" and "alt" on the
key, but not all.

> Do you mean instead of "Ctrl+<access_key>" it should return
"<some_symbol>+<access_key>"? If yes may I have some symbols can be used?

Ctrl: U+2303 UP ARROWHEAD (⌃)
Alt: U+2325 OPTION KEY (⌥)
Shift: U+21E7 UPWARDS WHITE ARROW (⇧)
Command: U+2318 PLACE OF INTEREST SIGN (⌘)

They should come in this order. Practically, on the Mac it will usually be ⌃⌥.

Marking r-, as you're going to modify the patch.