[webkit-reviews] review granted: [Bug 72879] [GTK] Add a way to skip unit tests in the bots : [Attachment 116078] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 21 07:28:46 PST 2011


Philippe Normand <pnormand at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 72879: [GTK] Add a way to skip unit tests in the bots
https://bugs.webkit.org/show_bug.cgi?id=72879

Attachment 116078: Patch
https://bugs.webkit.org/attachment.cgi?id=116078&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116078&action=review


Looks good, thanks! Just a little nit to fix before landing.

> Tools/Scripts/run-gtk-tests:79
> +	   raise

I don't think this works, raise needs a following exception, you should use the
traceback module:

import traceback
traceback.print_exc()


More information about the webkit-reviews mailing list