[webkit-reviews] review denied: [Bug 72733] Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS : [Attachment 116068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 21 07:09:26 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 72733: Web Inspector: [protocol] actual JSON messages do not conform to
Inspector.json in CSS
https://bugs.webkit.org/show_bug.cgi?id=72733

Attachment 116068: Patch
https://bugs.webkit.org/attachment.cgi?id=116068&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116068&action=review


> Source/WebCore/inspector/Inspector.json:1520
> +		       { "name": "styleId", "$ref": "CSSStyleId", "optional":
true, "description": "The CSS style identifier (absent for computed styles and
attribute styles)." },

You should use different structure for computed and matched styles.


More information about the webkit-reviews mailing list