[webkit-reviews] review denied: [Bug 72701] Web Inspector: [Protocol] Brush up retrieval of CSS styles for elements : [Attachment 115813] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 72701: Web Inspector: [Protocol] Brush up retrieval of CSS styles for
elements
https://bugs.webkit.org/show_bug.cgi?id=72701

Attachment 115813: Patch
https://bugs.webkit.org/attachment.cgi?id=115813&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115813&action=review


> Source/WebCore/inspector/InspectorCSSAgent.cpp:317
> +    unsigned forcePseudoState = computePseudoClassMask(forcedPseudoClasses ?
forcedPseudoClasses->get() : 0);

This logic is not trivial. Please do not copy-paste it.

> Source/WebCore/inspector/front-end/AuditRules.js:746
> +	       function inlineCallback(targetResult, inlineStyle,
styleAttributes)

You can define targetResult as a variable in the getStyles scope.

> LayoutTests/inspector/styles/styles-new-API.html:53
> +	   function computedCallback(error, computedStyle)

Why do we need this?