[webkit-reviews] review denied: [Bug 72007] A test for css parser number types problem. : [Attachment 114637] A test for CSS lexer rules, where the dimensions define like utf-8 code.

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Szilard Ledan
<Ledan-Muntean.Szilard at stud.u-szeged.hu>'s request for review:
Bug 72007: A test for css parser number types problem.
https://bugs.webkit.org/show_bug.cgi?id=72007

Attachment 114637: A test for CSS lexer rules, where the dimensions define like
utf-8 code.
https://bugs.webkit.org/attachment.cgi?id=114637&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114637&action=review


> LayoutTests/fast/css/parsing-css-number-types.html:13
> +#a { font-size: 16px; }
> +#b { font-size: 16\70\78; }
> +#c { font-size: 16\70x; }
> +#d { font-size: 16p\78; }
> +#e { font-size: 1em; }
> +#f { font-size: 1\65m; }
> +#g { font-size: 1\65\6D; }
> +#h { font-size: 1\65\6d; }
> +#i { font-size: 12pt }

Please add some uppercase / lowercase test here.
I.e: 12pT same as 12\70\54

Would be a good idea to add more number types (S, KhZ, gRaD). You can find them
in tokenizer.flex grouped in one block (lines starting with {num}).