[webkit-reviews] review granted: [Bug 72825] [Qt] Add WebView.view attached property support for dialogs in QML : [Attachment 115981] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 72825: [Qt] Add WebView.view attached property support for dialogs in QML
https://bugs.webkit.org/show_bug.cgi?id=72825

Attachment 115981: Patch
https://bugs.webkit.org/attachment.cgi?id=115981&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115981&action=review


r=me

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:143
> +    Q_PROPERTY(QQuickWebView* view READ view NOTIFY viewChanged)

I guess the property should also be marked FINAL?