[webkit-reviews] review requested: [Bug 72857] Optimize JITArithmetic32_64.cpp:: op_add & op_sub : [Attachment 116030] the patch

[bugzilla-daemon at webkit.org]

zeng huiqing <huiqing.zeng at intel.com> has asked  for review:
Bug 72857: Optimize JITArithmetic32_64.cpp:: op_add & op_sub
https://bugs.webkit.org/show_bug.cgi?id=72857

Attachment 116030: the patch
https://bugs.webkit.org/attachment.cgi?id=116030&action=review

------- Additional Comments from zeng huiqing <huiqing.zeng at intel.com>
With the patch, Performance result tested on Linux IA32 is here(ubuntu10.10,
DFG_JIT Disabled)
kraken:

TEST			     COMPARISON 	   FROM 		TO     
       DETAILS

=============================================================================

** TOTAL **:		     1.024x as fast    9858.5ms +/- 0.3%   9624.6ms +/-
0.3%	 significant

=============================================================================

  ai:			     -		       2049.5ms +/- 0.2%   2047.7ms +/-
0.2% 
    astar:		     -		       2049.5ms +/- 0.2%   2047.7ms +/-
0.2% 

  audio:		     -		       2292.7ms +/- 0.1%   2292.3ms +/-
0.1% 
    beat-detection:	     -			677.4ms +/- 0.3%    677.3ms +/-
0.3% 
    dft:		     -			578.4ms +/- 0.4%    578.4ms +/-
0.3% 
    fft:		     *1.005x as slow*	522.7ms +/- 0.1%    525.3ms +/-
0.2%	 significant
    oscillator: 	     1.006x as fast	514.2ms +/- 0.1%    511.3ms +/-
0.2%	 significant

  imaging:		     *1.019x as slow*  4146.8ms +/- 0.6%   4223.8ms +/-
0.5%	 significant
    gaussian-blur:	     *1.003x as slow*  2565.6ms +/- 0.1%   2573.0ms +/-
0.2%	 significant
    darkroom:		     *1.109x as slow*	672.7ms +/- 3.5%    746.2ms +/-
2.8%	 significant
    desaturate: 	     1.004x as fast	908.5ms +/- 0.1%    904.6ms +/-
0.2%	 significant

  json: 		     *1.009x as slow*	183.9ms +/- 0.3%    185.5ms +/-
0.5%	 significant
    parse-financial:	     -			 71.8ms +/- 0.4%     71.8ms +/-
0.4% 
    stringify-tinderbox:     *1.014x as slow*	112.1ms +/- 0.5%    113.7ms +/-
1.0%	 significant

  stanford:		     1.35x as fast     1185.6ms +/- 0.4%    875.3ms +/-
0.6%	 significant
    crypto-aes: 	     *1.011x as slow*	156.8ms +/- 0.3%    158.5ms +/-
0.8%	 significant
    crypto-ccm: 	     *1.014x as slow*	130.7ms +/- 0.5%    132.5ms +/-
1.0%	 significant
    crypto-pbkdf2:	     1.56x as fast	670.4ms +/- 0.6%    429.2ms +/-
0.7%	 significant
    crypto-sha256-iterative: 1.47x as fast	227.7ms +/- 0.3%    155.1ms +/-
0.6%	 significant