[webkit-reviews] review granted: [Bug 71779] Convert some placeholder-related tests to reftests : [Attachment 114019] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 20 19:37:26 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 71779: Convert some placeholder-related tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=71779

Attachment 114019: Patch 2
https://bugs.webkit.org/attachment.cgi?id=114019&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=114019&action=review


> LayoutTests/fast/forms/input-placeholder-text-indent-expected.html:10
> +<div style="direction:ltr">

Instead of direction, can we use text-align?

> LayoutTests/fast/forms/search-placeholder-value-changed-expected.html:1
> +<input type="search" placeholder="Test Passed">

Interesting to see how we have a separate test for type="text"
(placeholder-set-attribute-expected.html) and type="search" (this).


More information about the webkit-reviews mailing list