[webkit-reviews] review requested: [Bug 72646] Disable deprecation warnings around code where we cannot easily switch away from the deprecated APIs. : [Attachment 115999] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 20 14:40:50 PST 2011
Mark Rowe (bdash) <mrowe at apple.com> has asked for review:
Bug 72646: Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.
https://bugs.webkit.org/show_bug.cgi?id=72646
Attachment 115999: Patch v2
https://bugs.webkit.org/attachment.cgi?id=115999&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This switches to using “#pragma diagnostic clang” wrapped in “#if
COMPILER(CLANG)” since push / pop don’t work for GCC anyway. The fact it won’t
have any effect on GCC doesn’t matter since GCC isn’t a supported compiler for
WebKit on anything newer than SnowLeopard.
More information about the webkit-reviews
mailing list