[webkit-reviews] review denied: [Bug 72800] Web Inspector: Visual style of suggest pop-over : [Attachment 115950] Polishing pixels

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 19 23:54:00 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 72800: Web Inspector: Visual style of suggest pop-over
https://bugs.webkit.org/show_bug.cgi?id=72800

Attachment 115950: Polishing pixels
https://bugs.webkit.org/attachment.cgi?id=115950&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Two reasons I don't like it for:
1) We never use system colors in the front-end: we should either migrate
sidebars and DOM view to them first or hardcode selection color here as well
2) This new look will conflict with your other suggestion at
https://bugs.webkit.org/show_bug.cgi?id=72798 that we agreed upon. Prefix and
suggested suffix should be rendered consistently in text prompt and suggest
box.


More information about the webkit-reviews mailing list