[webkit-reviews] review granted: [Bug 72800] Web Inspector: Visual style of suggest pop-over : [Attachment 115950] Polishing pixels

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 72800: Web Inspector: Visual style of suggest pop-over
https://bugs.webkit.org/show_bug.cgi?id=72800

Attachment 115950: Polishing pixels
https://bugs.webkit.org/attachment.cgi?id=115950&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115950&action=review


> Source/WebCore/inspector/front-end/textPrompt.css:63
> +    color: HighlightText;
> +    background-color: Highlight;

We don't tend to use system named colors in the Inspector. But I see the appeal
here to match the selection color.

> Source/WebCore/inspector/front-end/textPrompt.css:67
> +    opacity: 0.5;

It is better to use a color instead of opacity. Opacity and subpixel text
antialiasing don't mix. But using HighlightText prevents that.