[webkit-reviews] review granted: [Bug 18039] dx causes non-BMP characters to fail to render : [Attachment 115919] patch, fixing style and no more constants

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 18039: dx causes non-BMP characters to fail to render
https://bugs.webkit.org/show_bug.cgi?id=18039

Attachment 115919: patch, fixing style and no more constants
https://bugs.webkit.org/attachment.cgi?id=115919&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115919&action=review


> Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp:211
> +		       // Handle surrogate pairs.

I think this assumes a correctly-formed surrogate pair. It’s not so great to do
that.