[webkit-reviews] review granted: [Bug 72768] Add CMake build infrastructure for the BlackBerry port : [Attachment 115916] BlackBerry-specific CMake files

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 72768: Add CMake build infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72768

Attachment 115916: BlackBerry-specific CMake files
https://bugs.webkit.org/attachment.cgi?id=115916&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115916&action=review


> Source/WebCore/PlatformBlackBerry.cmake:56
> +    platform/graphics/chromium/ComplexTextControllerLinux.cpp
> +    platform/graphics/chromium/FontCacheLinux.cpp
> +    platform/graphics/chromium/FontLinux.cpp
> +    platform/graphics/chromium/FontPlatformDataLinux.cpp
> +    platform/graphics/chromium/HarfbuzzSkia.cpp
> +    platform/graphics/chromium/SimpleFontDataLinux.cpp

we should definitively follow up with moving this code out of chromium/ into
harfbuzz/ or something like this.

> Source/WebCore/PlatformBlackBerry.cmake:322
> +#   storage/Database.idl
> +#   storage/DatabaseCallback.idl
> +#   storage/SQLError.idl
> +#   storage/SQLResultSet.idl
> +#   storage/SQLResultSetRowList.idl
> +#   storage/SQLStatementCallback.idl
> +#   storage/SQLStatementErrorCallback.idl
> +#   storage/SQLTransaction.idl
> +#   storage/SQLTransactionCallback.idl
> +#   storage/SQLTransactionErrorCallback.idl
> +#   storage/SQLTransactionSync.idl
> +#   storage/SQLTransactionSyncCallback.idl
> +#   workers/WebDOMDedicatedWorkerContext.idl
> +#   workers/WebDOMSharedWorkerContext.idl

commented out code? :)