[webkit-reviews] review granted: [Bug 71753] IDL changes for gamepad support : [Attachment 115898] retreat on Modules

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 71753: IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Attachment 115898: retreat on Modules
https://bugs.webkit.org/attachment.cgi?id=115898&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115898&action=review


> Source/WebCore/page/Navigator.cpp:35
> +#include "GamepadList.h"

Usually we put ifdefs around these sorts of headers so that folks who don't
enable this feature don't need to include it.  This file is missing a bunch of
those ifdefs, which is probably why you didn't add them.

> LayoutTests/gamepad/gamepad-api.html:3
> +<script src="gamepad-test.js"></script>

Is there some reason to use a gamepad-specific test harness rather than the
usual script test harness?