[webkit-reviews] review granted: [Bug 72311] Inline caches that refer to otherwise dead objects should be cleared : [Attachment 115764] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 16:33:46 PST 2011


Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 72311: Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311

Attachment 115764: the patch
https://bugs.webkit.org/attachment.cgi?id=115764&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115764&action=review


r=me

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1597
> +    visitor.addUnconditionalFinalizer(this);

Neat improvement over your prior patch.


More information about the webkit-reviews mailing list