[webkit-reviews] review denied: [Bug 18039] dx causes non-BMP characters to fail to render : [Attachment 115904] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 18039: dx causes non-BMP characters to fail to render
https://bugs.webkit.org/show_bug.cgi?id=18039

Attachment 115904: patch
https://bugs.webkit.org/attachment.cgi?id=115904&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115904&action=review


> Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp:210
> +		   if (currentCharacter >= 0xD800 && currentCharacter <=
0xDBFF) {

I'd love to see an isSurrogatePair() function we can use, rather than magic hex
values.