[webkit-reviews] review denied: [Bug 72753] [WK2][Qt] Move Accelerated Composite animations to UIProcess : [Attachment 115864] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Igor Trindade Oliveira
<igor.oliveira at webkit.org>'s request for review:
Bug 72753: [WK2][Qt] Move Accelerated Composite animations to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=72753

Attachment 115864: Patch
https://bugs.webkit.org/attachment.cgi?id=115864&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115864&action=review


Awesome! See comments, they are mainly nitpicks.

> Source/WebCore/ChangeLog:6
> +	   Add helper method to synchronize animations.

... in TextureMapper.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:987
> +void
TextureMapperNode::syncAnimationsRecursively(GraphicsLayerTextureMapper*
graphicsLayer)

The argument might not be necessary. See next comment.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:994
> +	   Vector<GraphicsLayer*> children = graphicsLayer->children();

You probably want to use the TextureMapperNode's children and not the
graphicsLayer's children, otherwise you might be syncing animations for items
that aren't in the synchronized tree yet.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:1000
> +	   }

early return.

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:129
> +    void updateSceneGraphUpdateTimerFired(Timer<LayerTreeHostProxy>*);

I believe the convention is didFireViewportUpdateTimer

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:130
> +    Timer<LayerTreeHostProxy> m_sceneGraphUpdateTimer;

Let's use viewport instead of scenegraph

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:283
> +#if PLATFORM(QT)

Why QT only? This seems cross-platform. Nobody else uses WebGraphicsLayer yet
so don't worry :)

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:306
> +#if PLATFORM(QT)

ditto

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:318
> +#if PLATFORM(QT)

ditto