[webkit-reviews] review denied: [Bug 72591] Remove document.width / document.height : [Attachment 115847] proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 72591: Remove document.width / document.height
https://bugs.webkit.org/show_bug.cgi?id=72591

Attachment 115847: proposed patch
https://bugs.webkit.org/attachment.cgi?id=115847&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115847&action=review


> LayoutTests/fast/dom/document-width-height-force-layout.html:-15
> -	       log("document.width = " + document.width);
> -	       log("document.height = " + document.height);

Can you change this test to use document.body.clientWidth and
document.body.clientHeight rather than remove it?

> LayoutTests/fullscreen/video-specified-size.html:-14
> -	       waitForEventTestAndEnd(document, 'webkitfullscreenchange',
"video.clientWidth==document.width");

Rather than removing this test, you can just change document.width on this line
to document.body.clientWidth.