[webkit-reviews] review granted: [Bug 71753] IDL changes for gamepad support : [Attachment 115857] rebase

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 71753: IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Attachment 115857: rebase
https://bugs.webkit.org/attachment.cgi?id=115857&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115857&action=review


If it's not too much trouble, would you be willing to put these files in
Source/WebCore/Modules/gamepad ?  We've been discussing creating a Modules
directory to hold these sorts of features, and your patch seems well timed to
be the guinea pig.  (If you'd rather not be a guinea pig, we can keep these in
page.)

Some minor nits below.

> Source/WebCore/page/Gamepad.h:26
> +

Please include ENABLE(GAMEPAD) guards in these header files.

> Source/WebCore/page/GamepadList.h:26
> +

ENABLE(GAMEPAD)

> Source/WebCore/page/Navigator.idl:66
> +	   readonly attribute [EnabledAtRuntime] GamepadList webkitGamepads;

You can use Conditional=GAMEPAD rather than #if statements.