[webkit-reviews] review granted: [Bug 72479] Accessibility: Multiselect list boxes need to report focus in addition to selection : [Attachment 115533] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 18 14:49:29 PST 2011
chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 72479: Accessibility: Multiselect list boxes need to report focus in
addition to selection
https://bugs.webkit.org/show_bug.cgi?id=72479
Attachment 115533: Patch
https://bugs.webkit.org/attachment.cgi?id=115533&action=review
------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115533&action=review
looks ok. one minor comment to fix before checking in
> Source/WebCore/accessibility/AccessibilityObject.h:414
>
I think this should be renamed to
isSelectedOptionActive()
and you should put a comment above to explain what it means
More information about the webkit-reviews
mailing list