[webkit-reviews] review granted: [Bug 71931] CSS 2.1 failure: outline-color-* tests fail : [Attachment 115843] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 71931: CSS 2.1 failure: outline-color-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71931

Attachment 115843: Patch
https://bugs.webkit.org/attachment.cgi?id=115843&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115843&action=review


> Source/WebCore/rendering/RenderObject.cpp:1155
> +    if (outer.isEmpty())

It took me some time to figure out why this was needed. Please add a comment
about the need to bail out when offset (could you rename it to outlineOffset
for coherency) is negative and bigger than outlineWidth (mentioning
fast/borders/outline-offset-min-assert.html and/or bug 12042). Also this is a
FIXME as this does not match FireFox anymore!