[webkit-reviews] review granted: [Bug 71309] Allow SVG elements to be transformed using webkit-transform : [Attachment 115604] Address styling issues and add more tests

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Raul Hudea <rhudea at adobe.com>'s
request for review:
Bug 71309: Allow SVG elements to be transformed using webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=71309

Attachment 115604: Address styling issues and add more tests
https://bugs.webkit.org/attachment.cgi?id=115604&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115604&action=review


Great tests. Since Nikolas said r=him I'll expect he's ok with this.

> Source/WebCore/ChangeLog:41
> +	   (WebCore::RenderSVGModelObject::styleWillChange):
> +   
> +	       Set the updateTransform flag on SVG elements whenever a CSS
transform is present on the style
> +
> +	   * svg/SVGStyledTransformableElement.cpp:
> +	   (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
> +
> +	       Use the RenderStyle's transform (if it exists) over the SVG's
transform
> +
> +	   * svg/SVGTextElement.cpp:
> +	   (WebCore::SVGTextElement::animatedLocalTransform):
> +
> +	       Use the RenderStyle's transform (if it exists) over the SVG's
transform

Typically these messages start from the same line as the filename.