[webkit-reviews] review denied: [Bug 72667] [Chromium] Fix broken DRT build for Aura Linux : [Attachment 115837] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 72667: [Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667

Attachment 115837: Patch
https://bugs.webkit.org/attachment.cgi?id=115837&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115837&action=review


One minor change, but otherwise, this looks great.

> Tools/DumpRenderTree/chromium/TestShellStub.cpp:34
> +#if OS(LINUX) && !USE(GTK)

I would remove the #if and instead, in WebKit.gyp, exclude the file except on
Aura.  That is, in the DumpRenderTree target, add the condition:
['use_aura==0', { 'sources/': [['exclude', 'Stub\\.cpp$']] } ].