[webkit-reviews] review denied: [Bug 71703] REGRESSION(r98542): Chromium: CSS text is rendered on page : [Attachment 115738] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied David Barr <davidbarr at chromium.org>'s
request for review:
Bug 71703: REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Attachment 115738: Patch
https://bugs.webkit.org/attachment.cgi?id=115738&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=115738&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:1270
> +    if (wasSimpleDefaultStyleSheet && defaultStyle)
> +	   m_matchStyleDeclarationCache.clear();

This code change won’t completely fix the problem. That’s because when
loadFullDefaultStyle is called, *all* CSSStyleSelector objects would need to
have their match style declarations caches cleared. Not just the one that
triggered the call to loadFullDefaultStyle.

Not sure the best way to structure the code to make that happen, though.