[webkit-reviews] review granted: [Bug 72016] [Chromium] [WebSocket] export WebSocketChannel interface for plugins : [Attachment 115761] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Takashi
Toyoshima <toyoshim at chromium.org>'s request for review:
Bug 72016: [Chromium] [WebSocket] export WebSocketChannel interface for plugins
https://bugs.webkit.org/show_bug.cgi?id=72016

Attachment 115761: Patch
https://bugs.webkit.org/attachment.cgi?id=115761&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115761&action=review


> Source/WebKit/chromium/src/WebSocket.cpp:43
> +    WebSocketImpl* websocket = new WebSocketImpl(document, client);

nit: WebKit style is to use OwnPtr here.

  OwnPtr<WebSocketImpl> websocket = adoptPtr(new WebSocketImpl(document,
client));
  if (websocket && websocket->isNull())
      return 0;
  return websocket.leakPtr();